[Fleet] Render extension component after initializing package policy #150096
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
extracted from #149137 (comment):
sometimes
validationErrors
andpackagePolicy
goes out of sync:this happens when our extension component fires an effect on mount to initialize the package policy before fleet's effect (
init()
)making this property stateful makes the extension component render only after fleet's effect has fired, which sorts out the ordering.
still kinda odd they are not in sync tho, even if fleet's effect fires last, i'd expect the policy to be changed as well. you can check the logs and reproduce this on env by going to the install page -> canceling and going in again
@nchaulet
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers